Add scene API by noclone · Pull Request #3417 · f3d-app/f3d

noclone · 2026-07-27T10:22:07Z

Describe your changes

Add scene API

Issue ticket number and link if any

#2937

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

I have not used AI to generate any of the content of this pull request
I have used AI to generate code in this pull request:
- I have carefully read and understood the AI policy.
- I have carefully reviewed and completely understood every generated line.
- I disclose below which parts of the code were generated and with which AI model:
  I used Opus 5 to generate some parts of the code (eg. SetSubtreeVisibility), which I then reworked myself.
  ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

github-actions · 2026-07-27T10:22:17Z

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

mwestphal · 2026-07-27T11:12:58Z

missing AI disclosure

noclone · 2026-07-27T11:47:52Z

missing AI disclosure

Done
I usally do I once the PR is ready for a full review

mwestphal · 2026-07-27T12:22:54Z

missing AI disclosure

Done I usally do I once the PR is ready for a full review

You did request a review though, it least I recieved a review request.

noclone · 2026-07-27T12:25:22Z

missing AI disclosure

Done I usally do I once the PR is ready for a full review

You did request a review though, it least I recieved a review request.

You did ?
I mean I asked meak to give his opinion on the design on discord but I didn't request a review on github.
Maybe you receive one automatically when the PR is not a draft ?

mwestphal · 2026-07-27T12:28:47Z

one automatically when the PR is not a draft ?

Indeed :)

Please create a PR in draft mode unless ready for review: https://f3d.app/dev/CONTRIBUTING#f3d-development-workflow

noclone · 2026-07-27T12:30:44Z

one automatically when the PR is not a draft ?

Indeed :)

Please create a PR in draft mode unless ready for review: https://f3d.app/dev/CONTRIBUTING#f3d-development-workflow

my bad, will do

mwestphal

not rdy yet.

noclone · 2026-07-28T07:39:40Z

\ci fast

Meakk

That looks pretty good!

Meakk · 2026-07-29T21:21:18Z

    assert engine.scene.get_added_files() == []
+
+
+def test_scene_hierarchy():


@snoyer can you check if usage is pythonic?

I'm assuming it is :)

Meakk

Looks good to me, you can run the full CI and ping me again when it's green.

noclone · 2026-07-31T15:12:49Z

\ci full

mwestphal

some changes, but i have yet to review the implementation properly

codecov · 2026-07-31T17:03:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (1c6d1a9) to head (540ce0e).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3417      +/-   ##
==========================================
+ Coverage   97.04%   97.07%   +0.03%     
==========================================
  Files         216      216              
  Lines       18784    18920     +136     
==========================================
+ Hits        18229    18367     +138     
+ Misses        555      553       -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwestphal

lgtm, ill test when I can. needs a @Meakk review though.

mwestphal · 2026-08-01T06:25:45Z

Cannot cover the remaining lines ?

noclone · 2026-08-01T07:48:06Z

Cannot cover the remaining lines ?

I had missed them, they are now covered

noclone requested a review from a team as a code owner July 27, 2026 10:22

noclone marked this pull request as draft July 27, 2026 12:30

mwestphal reviewed Jul 27, 2026

View reviewed changes

mwestphal added the ci:fast label Jul 28, 2026

noclone marked this pull request as ready for review July 28, 2026 18:06

mwestphal linked an issue Jul 29, 2026 that may be closed by this pull request

Add f3d::scene API to handle the scene hierarchy #2937

Open

noclone requested a review from mwestphal July 29, 2026 07:23

Meakk reviewed Jul 29, 2026

View reviewed changes

Comment thread java/F3DSceneBindings.cxx Outdated

Meakk requested changes Jul 29, 2026

View reviewed changes

noclone added 5 commits July 29, 2026 23:39

Add scene API

62852e0

Add level in struct

3836cbd

Add tests & bindings for scene api

6948afe

inline helpers

62c0999

Fixes

9265820

noclone force-pushed the scene-api branch from 4996261 to 9265820 Compare July 30, 2026 07:14

mwestphal reviewed Jul 30, 2026

View reviewed changes

Comment thread library/public/types.h

mwestphal requested changes Jul 30, 2026

View reviewed changes

Describe each member

9b0e4f4

mwestphal reviewed Jul 30, 2026

View reviewed changes

Comment thread library/public/types.h Outdated

fix doc

bcbc2d5

noclone requested review from Meakk and mwestphal July 31, 2026 07:18

Meakk reviewed Jul 31, 2026

View reviewed changes

mwestphal added the ci:full label Jul 31, 2026

mwestphal reviewed Jul 31, 2026

View reviewed changes

Comment thread library/public/scene.h

mwestphal reviewed Jul 31, 2026

View reviewed changes

Comment thread python/F3DPythonBindings.cxx

mwestphal requested changes Jul 31, 2026

View reviewed changes

Comment thread webassembly/F3DEmscriptenBindings.cxx

mwestphal self-requested a review July 31, 2026 15:33

noclone added 2 commits July 31, 2026 18:02

Add js test

5286b29

Fix errrors

7da96f5

noclone requested a review from Meakk July 31, 2026 21:18

mwestphal requested changes Aug 1, 2026

View reviewed changes

Comment thread vtkext/private/module/vtkF3DMetaImporter.cxx

Comment thread vtkext/private/module/vtkF3DMetaImporter.cxx Outdated

Comment thread python/F3DPythonBindings.cxx

fix & add final coverage

540ce0e

noclone requested a review from mwestphal August 1, 2026 08:44

		assert engine.scene.get_added_files() == []


		def test_scene_hierarchy():

Uh oh!

Uh oh!

Conversation

noclone commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

AI Disclosure

Continuous integration

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

mwestphal commented Jul 27, 2026

Uh oh!

noclone commented Jul 27, 2026

Uh oh!

mwestphal commented Jul 27, 2026

Uh oh!

noclone commented Jul 27, 2026

Uh oh!

mwestphal commented Jul 27, 2026

Uh oh!

noclone commented Jul 27, 2026

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

noclone commented Jul 28, 2026

Uh oh!

Uh oh!

Meakk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Meakk Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Meakk Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Meakk left a comment

Choose a reason for hiding this comment

Uh oh!

noclone commented Jul 31, 2026

Uh oh!

Uh oh!

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mwestphal commented Aug 1, 2026

Uh oh!

noclone commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

noclone commented Jul 27, 2026 •

edited

Loading

codecov Bot commented Jul 31, 2026 •

edited

Loading