Skip to content

doc: Add documentation styleguide, update some docs to adhere - #3397

Open
enjeck wants to merge 5 commits into
f3d-app:masterfrom
enjeck:improve-doc
Open

doc: Add documentation styleguide, update some docs to adhere#3397
enjeck wants to merge 5 commits into
f3d-app:masterfrom
enjeck:improve-doc

Conversation

@enjeck

@enjeck enjeck commented Jul 19, 2026

Copy link
Copy Markdown

Describe your changes

  • add a documentation style guide
  • update some docs to adhere to this style guide
  • fix spelling and grammatical errors
  • make docs more consistent e.g capitalization, title casing

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I have not used AI to generate any of the content of this pull request
  • I have used AI to generate code in this pull request:
    • I have carefully read and understood the AI policy.
    • I have carefully reviewed and completely understood every generated line.
    • I disclose below which parts of the code were generated and with which AI model:
      • Claude Opus 4.8 to come up with the good vs bad examples in the style guide, based on F3D's code and use cases

...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@enjeck
enjeck requested a review from a team as a code owner July 19, 2026 11:05
@mwestphal

Copy link
Copy Markdown
Member

Please properly disclose AI usage in the PR description.

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing AI disclosure.

@mwestphal

Copy link
Copy Markdown
Member

Please request a review, top right, whenever needed @enjeck :)

@enjeck
enjeck requested a review from mwestphal July 27, 2026 05:26
Comment thread doc/dev/09-CODING_STYLE.md
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md Outdated
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md Outdated
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md Outdated
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md Outdated
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md Outdated
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md
Comment thread doc/dev/15-DOCUMENTATION_STYLE.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
- **Documentation only**: no build is required. Write your changes following the [documentation style guide](doc/dev/15-DOCUMENTATION_STYLE.md), then preview them with the [website preview recipe](doc/dev/07-TOOLING.md#how-to-locally-generate-and-run-the-website).
- **Code contributions**: start with our [Getting Started guide](doc/dev/04-GETTING_STARTED.md), then follow the [Build guide](doc/dev/05-BUILD.md). After that, read the [Architecture](doc/dev/08-ARCHITECTURE.md) page and the [F3D mentoring program](doc/dev/13-MENTORING.md) if you want more guidance.

Once you know which path applies, take a look at the open [issues](https://github.com/f3d-app/f3d/issues).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the help wanted link ? many issues are not available to pick up by anyone.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see this change

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular work @enjeck !

@mwestphal
mwestphal requested a review from Meakk July 27, 2026 06:42
@enjeck enjeck mentioned this pull request Jul 27, 2026
10 tasks
@enjeck
enjeck requested a review from mwestphal July 28, 2026 16:20
@mwestphal

Copy link
Copy Markdown
Member

\ci website

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i've run the website CI

@mwestphal
mwestphal self-requested a review July 28, 2026 17:27
@mwestphal

Copy link
Copy Markdown
Member

Nice, lets wait for @Meakk review.

@Meakk Meakk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarification, but it looks very good, thanks :)

| plugin | reader module, extension, unless explaining internals |
| reader | importer, loader, unless the code/API uses those names |
| file format | file type, when referring to the supported formats table |
| rendering backend | OpenGL backend, when referring to `--rendering-backend` |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It applies to the "OpenGL context", or "rendering window".
I think it may be too ambiguous to talk about "OpenGL backend"

Suggested change
| rendering backend | OpenGL backend, when referring to `--rendering-backend` |
| rendering backend | OpenGL context backend, when referring to `--rendering-backend` |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants