Skip to content

ISSUE #3100: Add support for different animations mode, reverse, ping pong, looping or not - #3385

Draft
12alkry45 wants to merge 4 commits into
f3d-app:masterfrom
12alkry45:feat-animation-modes
Draft

ISSUE #3100: Add support for different animations mode, reverse, ping pong, looping or not#3385
12alkry45 wants to merge 4 commits into
f3d-app:masterfrom
12alkry45:feat-animation-modes

Conversation

@12alkry45

@12alkry45 12alkry45 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Add --animation-mode and --animation-repeat CLI options. You can choose the mode of the animation: backward, forward or pingpong. Set the number of repeats to the animation.

Issue ticket number and link if any

ISSUE #3100: Add support for different animations mode, reverse, ping pong, looping or not

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I have not used AI to generate any of the content of this pull request
  • I have used AI to generate code in this pull request:
    • I have carefully read and understood the AI policy.
    • I have carefully reviewed and completely understood every generated line.
    • I disclose below which parts of the code were generated and with which AI model:

...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal

Copy link
Copy Markdown
Member

@12alkry45 please disclose AI usage in the PR description

@12alkry45

Copy link
Copy Markdown
Contributor Author

@12alkry45 please disclose AI usage in the PR description

I only used Google (AI search) for internal/informational research. No code or PR text was generated by AI. Since I haven't completed the issue yet, I thought I'd check the box later, but, okay, it's indeed important, sorry)

@mwestphal

Copy link
Copy Markdown
Member

@12alkry45 please disclose AI usage in the PR description

I only used Google (AI search) for internal/informational research. No code or PR text was generated by AI. Since I haven't completed the issue yet, I thought I'd check the box later, but, okay, it's indeed important, sorry)

No worries, we are being swamped by ai PRs atm, so we are checking right away.
Do not hesitate to modify the ai disclosure during the PR if you need to :)

@12alkry45
12alkry45 force-pushed the feat-animation-modes branch from 4f4554c to dd6eb26 Compare July 16, 2026 11:35
@12alkry45

Copy link
Copy Markdown
Contributor Author

\ci fast

@12alkry45

12alkry45 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Hello, @mwestphal , could you please review the code before I add tests and update docs? might be I have missed smth

@github-actions

Copy link
Copy Markdown

❌ Invalid CI command "fast"

@12alkry45

Copy link
Copy Markdown
Contributor Author

Hello, @mwestphal , could you please review the code before I add tests and update docs? might be I have missed smth

@mwestphal
mwestphal self-requested a review July 20, 2026 15:13
@mwestphal

Copy link
Copy Markdown
Member

Sorry I missed this. Ill review.

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! please move forward with doc and tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for different animations mode, reverse, ping pong, looping or not

2 participants