Fix exception inheritance - #3323
Conversation
|
It's a draft, the CI should fail, and I will push the fix next. |
|
ci is not failing though ? |
|
Let me try with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3323 +/- ##
==========================================
+ Coverage 96.91% 97.03% +0.11%
==========================================
Files 212 212
Lines 19134 17818 -1316
==========================================
- Hits 18543 17289 -1254
+ Misses 591 529 -62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Interesting, it's macos specific. Failure can be found here: https://github.com/f3d-app/f3d/actions/runs/28516264087/job/84531428334?pr=3323#step:3:7719 |
|
You are modifying libf3d public API! |
|
And now it breaks on Windows lol |
mwestphal
left a comment
There was a problem hiding this comment.
no review needed for now I suppose ?
nop, I'll get back to it later. |
Describe your changes
Fix
f3d::exceptionvisibility.Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.