Skip to content

Fix exception inheritance - #3323

Open
Meakk wants to merge 4 commits into
f3d-app:masterfrom
Meakk:fix-exception-visibility
Open

Fix exception inheritance#3323
Meakk wants to merge 4 commits into
f3d-app:masterfrom
Meakk:fix-exception-visibility

Conversation

@Meakk

@Meakk Meakk commented Jul 1, 2026

Copy link
Copy Markdown
Member

Describe your changes

Fix f3d::exception visibility.

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Jul 1, 2026
@Meakk Meakk added the ci:fast label Jul 1, 2026
@Meakk

Meakk commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

It's a draft, the CI should fail, and I will push the fix next.

@mwestphal

Copy link
Copy Markdown
Member

ci is not failing though ?

@Meakk Meakk added ci:main and removed ci:fast labels Jul 1, 2026
@Meakk

Meakk commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Let me try with main. It fails locally on my mac.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (fcfa401) to head (64f9f28).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3323      +/-   ##
==========================================
+ Coverage   96.91%   97.03%   +0.11%     
==========================================
  Files         212      212              
  Lines       19134    17818    -1316     
==========================================
- Hits        18543    17289    -1254     
+ Misses        591      529      -62     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Meakk

Meakk commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Interesting, it's macos specific. Failure can be found here: https://github.com/f3d-app/f3d/actions/runs/28516264087/job/84531428334?pr=3323#step:3:7719

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@Meakk Meakk added ci:full and removed ci:main labels Jul 1, 2026
@Meakk
Meakk marked this pull request as ready for review July 1, 2026 15:27
@Meakk
Meakk requested a review from a team as a code owner July 1, 2026 15:27
@Meakk

Meakk commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

And now it breaks on Windows lol

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no review needed for now I suppose ?

@Meakk

Meakk commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

no review needed for now I suppose ?

nop, I'll get back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants