Initial XR support - #3245
Conversation
|
You are modifying libf3d public API! |
ab981be to
308a5c4
Compare
|
\ci fast |
c73a8a1 to
f391604
Compare
f9a4f4c to
7c9b1e4
Compare
Meakk
left a comment
There was a problem hiding this comment.
Here's a first review. I'll try your branch before going more in depth.
88ac1e5 to
0228731
Compare
|
please rebase on master @AoGao-Kedoka |
mwestphal
left a comment
There was a problem hiding this comment.
Quick high level review.
Please capitalize it: XR or do not capitalize it at all xr depending of the context.
mwestphal
left a comment
There was a problem hiding this comment.
missing doc.
make sure to document which libf3d and cli options have no effect in XR mode
| this->FrameBufferObject->StartNonOrtho(size[0], size[1]); | ||
| this->DelegatePass->Render(state); | ||
| this->FrameBufferObject->RemoveColorAttachments(1); | ||
| this->FrameBufferObject->UnBind(); |
There was a problem hiding this comment.
is this a change in behavior ?
There was a problem hiding this comment.
Not in our use case. RenderDelegate supports rendering into an another image size, which it will create a new temporary camera. Copying a vtkOpenXRCamera into a vtkCamera would cause data loss, hence rendering result changes.
In our case we never render into an another image size, so the behavior should be the same.
There was a problem hiding this comment.
in resources/xr_actions_manifests/ add a .md file acknolowdging the origin of the files and their license and copyright.
Describe your changes
Adding XR support in rendering. Interactions will be handled in another future PR.
Steps to build and test
https://www.kitware.com/using-vtk-with-the-meta-quest/
-DF3D_MODULE_OPENXR=ONf3d ../testing/data/<data>.<datatype> --rendering-backend=xrChecklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
GPT5.5 for Creating the bounding box and align objects to the bounding box. Reviewed and tested carefully.
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.