fix(compute): allow unlisted template IDs - #888
Draft
natalie-o-perret wants to merge 9 commits into
Draft
Conversation
natalie-o-perret
changed the base branch from
master
to
fix/template-disk-size-default
August 4, 2026 17:21
2 tasks
natalie-o-perret
marked this pull request as draft
August 4, 2026 17:29
Contributor
Author
|
[SC-191635] |
…into fix/unlisted-template-ids # Conflicts: # cmd/compute/instance/instance_create.go # cmd/compute/instance_pool/instance_pool_create.go
…into fix/unlisted-template-ids # Conflicts: # cmd/compute/instance/instance_create.go # cmd/compute/instance_pool/instance_pool_create.go
…into fix/unlisted-template-ids # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some valid public template IDs, including templates used by A1, are intentionally omitted from
ListTemplates. Compute commands currently treat that list as an existence check and reject those IDs before the authoritative API sees them.This change passes UUID template references directly to the create and update APIs while retaining list lookup for template names. It covers instance create/reset and instance pool create/update.
Follow-up to #882. When #882 is rebased, its size lookup must remain optional for UUIDs omitted from
ListTemplates.Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
make test-verbosepassed all race-enabled unit tests, includingTestResolveTemplateIDPassesUUIDThrough.go test -vfromtests/e2epassed all API-free scripts.make lint,go vet ./...,golangci-lint run --timeout 4m,make build, andgovulncheck ./...completed successfully;govulncheckreported zero reachable vulnerabilities.Note
AI assistance: conflict resolution, test scaffolding, PR description.