feat(site): show projects in homepage hero - #2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fd5f62ab2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <a | ||
| class="home-project-card" | ||
| data-testid="home-project-card" | ||
| href={project.repository} |
There was a problem hiding this comment.
Avoid linking the homepage card to a missing driver
When visitors click the first newly rendered project card, this href resolves to driver/reference on main, but a repository-wide search shows that only the empty top-level driver/ directory exists and no driver/reference artifact is generated. The homepage therefore promotes a “可运行” project that immediately returns a GitHub 404; omit this card or point it at an existing reference snapshot until the real driver target is implemented.
AGENTS.md reference: AGENTS.md:L7-L12
Useful? React with 👍 / 👎.
| .hero-stage { | ||
| height: calc(100svh - 86px); | ||
| min-height: 0; |
There was a problem hiding this comment.
Preserve hero content in short mobile viewports
On short mobile or landscape viewports, the fixed stage height leaves almost no room above the project rail: at 667×375, this computes to 289px while the rail consumes 218px plus a 12px bottom offset, leaving only 59px for the heading and buttons. Because .hero-stage also has overflow: hidden, most of that content is clipped or covered despite the short-height rule hiding only the lede and specs; add a compact short-mobile layout or a usable minimum height.
Useful? React with 👍 / 👎.
Summary / 概要
Verification / 验证
bun run check:0 errors / 0 warningsbun run test:unit:5/5 passedbun run test:e2e:16/16 passedbun run build:13 pages built