feat: launch OpenEPD 4.7 documentation website - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6d6cfb22c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| repository: 'https://github.com/exomind-team/openepd-47/tree/main/driver/reference', | ||
| status: '可运行', |
There was a problem hiding this comment.
Remove the nonexistent runnable driver entry
This entry is shown to users as “可运行”, but its repository URL points to driver/reference, which does not exist anywhere in the repository; the only imported ebook firmware is under materials/reference-firmware/ebook/, and it explicitly lacks the GT911 integration claimed in the summary. The project card therefore sends users to a 404 while falsely presenting unfinished reference material as a working driver.
AGENTS.md reference: AGENTS.md:L7-L12
Useful? React with 👍 / 👎.
| if (!redistribution) errors.push(`${id}: redistribution 不能为空`); | ||
|
|
||
| if (sourceType === 'external-link') { |
There was a problem hiding this comment.
Reject unknown provenance and authorization values
When a resource contains a typo or unsupported value such as sourceType: external_link or redistribution: authorzied, this validator accepts it as long as the field is nonempty. Because the YAML is only type-cast later, such records pass CI and are then classified by the catalog's fallback branches, potentially presenting an external document as a local mirror or displaying the wrong authorization status; validate both fields against their closed sets.
AGENTS.md reference: AGENTS.md:L35-L36
Useful? React with 👍 / 👎.
| "build": "astro check && astro build", | ||
| "preview": "astro preview", | ||
| "check": "astro check && bun run validate:resources", |
There was a problem hiding this comment.
Run resource validation in the production build
When bun run build is invoked directly—including by the Pages build in .github/workflows/pages.yml—it runs only Astro checks and compilation, while file existence and SHA-256 validation live in the separate check script. A direct push or manual Pages dispatch can therefore successfully deploy entries whose downloads are missing or corrupted; make the production build invoke validate:resources rather than relying solely on the pull-request workflow.
AGENTS.md reference: AGENTS.md:L32-L36
Useful? React with 👍 / 👎.
Summary / 概要
Verification / 验证
bun run check:通过bun run test:unit:5/5 通过bun run test:e2e:13/13 通过bun run build:13 个静态页面构建成功Invoke-Pester scripts/tests/prepare-materials.Tests.ps1:6/6 通过Invoke-Pester scripts/tests/repository-integrity.Tests.ps1:1/1 通过