Skip to content

[perfect-numbers] Add a Jinja test template#853

Merged
IsaacG merged 1 commit into
exercism:mainfrom
IsaacG:pygen.perfect-numbers
Jun 29, 2026
Merged

[perfect-numbers] Add a Jinja test template#853
IsaacG merged 1 commit into
exercism:mainfrom
IsaacG:pygen.perfect-numbers

Conversation

@IsaacG

@IsaacG IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member

This updates the error message to match the problem specs, breaking existing solutions.

@IsaacG IsaacG added x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the solution file, the example file, that no longer is correct for the change in the generated test?

Comment thread exercises/practice/perfect-numbers/.meta/example.sh Outdated
@IsaacG IsaacG force-pushed the pygen.perfect-numbers branch from aad20d3 to 77c67b5 Compare June 29, 2026 06:29
@IsaacG

IsaacG commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Is the solution file, the example file, that no longer is correct for the change in the generated test?

bash had "natural numbers". The problem spec has "positive integers". I accidentally changed the example solution from "natural numbers" to "positive numbers", correcting one of the two words.

The example is now in sync with the problem specs.

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, passing all tests.

@IsaacG IsaacG merged commit 8d1ed39 into exercism:main Jun 29, 2026
3 checks passed
@IsaacG IsaacG deleted the pygen.perfect-numbers branch June 29, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:size/medium Medium amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants