Skip to content

Part of support non editable workflows: discovery end-point - #247

Merged
woutdenolf merged 7 commits into
mainfrom
72-support-non-editable-workflows
Aug 2, 2026
Merged

Part of support non editable workflows: discovery end-point#247
woutdenolf merged 7 commits into
mainfrom
72-support-non-editable-workflows

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Jul 13, 2026

Copy link
Copy Markdown
Member

Partial implementation of non-editable workflow support:

  • New API version v2_1_0
  • add POST /api/workflows/discover in analogy to POST /api/tasks/discover + tests in analogy to ewoksjob tests and ewokserver task discovery tests
  • discover on startup like tasks

Needs ewoksjob v1.6.0rc1 which exposes workflow discovery to clients.

The server does not do anything yet with the discovered workflows.

@woutdenolf woutdenolf linked an issue Jul 13, 2026 that may be closed by this pull request
Comment thread src/ewoksserver/app/routes/common/discovery.py
Comment thread src/ewoksserver/tests/conftest.py
@woutdenolf woutdenolf changed the title 72 support non editable workflows Part of support non editable workflows: discovery end-point Jul 13, 2026
@woutdenolf
woutdenolf force-pushed the 72-support-non-editable-workflows branch from acc16bd to bc638d3 Compare July 13, 2026 16:09
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.43697% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksserver/app/routes/common/discovery.py 91.02% 7 Missing ⚠️
src/ewoksserver/app/lifespan.py 77.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@woutdenolf
woutdenolf requested a review from a team July 13, 2026 16:42
@woutdenolf

woutdenolf commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

I will push some debug/fix commits for CI but does not fundamentally change the PR.

Edit: the remaining issues are caused by concurrent reading/writing to sqlite db. See ewoks-kit/ewoksjob#344.

Comment thread src/ewoksserver/app/routes/common/discovery.py Outdated
Comment thread src/ewoksserver/app/routes/workflows/router.py
@woutdenolf
woutdenolf merged commit dbd2298 into main Aug 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants