Update commons-codec to 1.22.1 - #195
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThe build definition updates ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
build.sbt (1)
25-25: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winAdd a legacy ciphertext regression test.
Crypto.scala:110-121usesBase64.decodeBase64, but the suppliedCryptoSpec.scala:16-24test encrypts and decrypts data in the same run. Add a fixed ciphertext fixture created with Commons Codec 1.15 and verify decryption with 1.22.1.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@build.sbt` at line 25, Add a regression test in CryptoSpec.scala that decrypts a fixed ciphertext fixture generated with Commons Codec 1.15, using the production decryption path in Crypto.scala rather than encrypting the value during the test. Keep the existing round-trip test and assert that the legacy fixture decrypts to the expected plaintext under Commons Codec 1.22.1.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@build.sbt`:
- Line 25: Add a regression test in CryptoSpec.scala that decrypts a fixed
ciphertext fixture generated with Commons Codec 1.15, using the production
decryption path in Crypto.scala rather than encrypting the value during the
test. Keep the existing round-trip test and assert that the legacy fixture
decrypts to the expected plaintext under Commons Codec 1.22.1.
|



About this PR
📦 Updates commons-codec:commons-codec from
1.15to1.22.1Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
Summary by CodeRabbit