Omit Google Pay billingAddressParameters when billing is not required - #987
Merged
Max Harrison (maxharrison) merged 2 commits intoAug 24, 2026
Merged
Conversation
The web request always sent billingAddressParameters, even when billingAddressRequired was false. Google ignores the field in that case, so the payment sheet does not change, but the request claimed a FULL address format that we never asked for. Omitting the field makes the request say only what it means, and matches the Android SDK.
🦋 Changeset detectedLatest commit: 20ba221 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Aug 20, 2026
Contributor
Author
|
Should we release a changeset with this? |
ana-maksimovskikh
approved these changes
Aug 24, 2026
ana-maksimovskikh
left a comment
ana-maksimovskikh
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thank you 🙏
Max Harrison (maxharrison)
deleted the
max/gpay-omit-billing-address-parameters-v2
branch
August 24, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildPaymentRequestsentbillingAddressParameterseven whenbillingAddressRequiredwasfalse. Google ignores those parameters, but the request still claimed aFULLbilling address format that the merchant did not request.The request now omits
billingAddressParametersunless billing collection is enabled. This does not change the Google Pay sheet, and it matches the Android request for the disabled case.Stack: #985 adds golden request tests on top of this PR.