Skip to content

fix: auto complete for credit card fields - #115

Open
Jake Grogan (jakekgrog) wants to merge 1 commit into
mainfrom
jake/card-1008-android-autocomplete-for-credit-card-fields
Open

fix: auto complete for credit card fields#115
Jake Grogan (jakekgrog) wants to merge 1 commit into
mainfrom
jake/card-1008-android-autocomplete-for-credit-card-fields

Conversation

@jakekgrog

@jakekgrog Jake Grogan (jakekgrog) commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

Customer reported the credit card, expiry, and CVC fields showed no Android autofill suggestions above the keyboard.

  • The fields used Compose's legacy Autofill API, which Google has effectively deprecated because it doesn't reliably expose a Compose field's type to the platform's Autofill framework. The SDK's Compose BOM also predated the newer, stable autofill API, so there was no way to adopt it without upgrading first.
  • Bumped the Compose BOM in evervault-inputs to Compose UI 1.8.3, which includes the stable semantics-based ContentType autofill API.
  • Replaced the AutofillNode/LocalAutofillTree wiring in CustomTextField.kt and PaymentCardInputScopeImpl.kt with Modifier.semantics { contentType = ContentType.CreditCardNumber/CreditCardExpirationDate/CreditCardSecurityCode }, and call LocalAutofillManager.commit() on IME "Done" to still trigger the save-card prompt.

How

Tested by installing the sample app on my phone and verified there is now an autofill option for the credit card fields

@jakekgrog
Jake Grogan (jakekgrog) requested a review from a team as a code owner July 9, 2026 10:36
@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 433c76e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedmaven/​org.jspecify/​jspecify@​1.0.010010090100100

View full report

@jakekgrog Jake Grogan (jakekgrog) changed the title fix: auto complete for credicard fields fix: auto complete for credit card fields Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants