Repository navigation
feat: add Hugging Face Hub as test data source support for SDK- #169 - #191
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe SDK adds Hugging Face Hub repositories as ChangesHugging Face test data
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant CLI as eval run
participant Model as HFTestDataRef
participant Client as EvalHub client
CLI->>Model: Create repository reference
Model-->>CLI: Validate hf test-data source
CLI->>Client: Submit test-data reference
Client-->>Client: Omit resolved_sha from submission
Merge Risk: ⚪ Minimal · up to The Hugging Face test-data feature is wired through the SDK and CLI with validation and unit coverage; no actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d39b0d8 to
f8e88d8
Compare
Add HFTestDataRef (repo_id, revision, sub_path, secret_ref) and extend TestDataRef one-of validation to s3/pvc/git/hf. Wire --test-data-hf-* flags on eval run with mutual-exclusion checks. Add model, client submit, and CLI unit tests mirroring git test-data support from eval-hub#169. Assisted-by: Cursor Signed-off-by: Sobha Cheruku <scheruku@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
f8e88d8 to
63f4ce1
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
What and why
Implements SDK and CLI support for Hugging Face Hub test data, matching the server-side changes from https://github.com/eval-hub/eval-hub/pull/996/changes
Closes # https://redhat.atlassian.net/browse/RHAISTRAT-2059
Type
Testing
Testing:
Job completed successfully
Breaking changes
Summary by CodeRabbit
New Features
Tests