Repository navigation
Conversation
Previously, nodes forwarded only the first bid from each builder for a slot and parent, so a builder could not update a bid once it was sent. Nodes now accept one bid per ETH of builder balance for each slot and parent, capped at `MAX_BIDS_PER_BUILDER_PER_SLOT` (32 for now). Each extra bid must still beat the highest bid seen. The limit depends on the builder's balance, so the check now runs after the builder is loaded rather than at the top of gossip validation. The seen-bids set becomes a counter, like Heze's inclusion list counts, and the change is carried into Heze and the features that redefine `Seen`.
github-actions
Bot
added
testing
The cap did not bound the total number of bids. Registering another builder only takes a deposit, so a builder can split its stake across identities and still get one bid per ETH. In practice the cap mostly turned the limit into a flat 32 bids for well-staked builders. The bid limit is now one bid per ETH of builder balance, with no upper bound.
The bid limit gossip test already exercises `get_builder_bid_limit`, so these unit tests add little coverage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, nodes forwarded only the first bid from each builder for a slot and parent. Nodes now accept one bid per ETH of builder balance for each slot and parent; for example, a builder with a balance of 7 ETH can submit 7 bids. Each extra bid must still beat the highest bid seen. Instead of creating multiple builders with different keys to send multiple bids, now they can manage a single one. This should reduce state growth.