Skip to content

[WIP] Fix issue with comments not saving in read-only pad#398

Draft
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-comments-in-read-only-pad
Draft

[WIP] Fix issue with comments not saving in read-only pad#398
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-comments-in-read-only-pad

Conversation

Copy link
Copy Markdown

Copilot AI commented May 13, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>comment in a read-only Pad?</issue_title>
<issue_description>How do you think? Could it be possible to comment in a read-only Pad?
They are stored to database, too

key:

comments:padID 

value:

"commentId":{ "author": data.author, "name": data.name, "text": data.text, "changeTo": data.changeTo, "changeFrom": data.changeFrom, "timestamp": new Date().getTime()}

(commentManager.js, line 62, right?)

But in

key:

pad:padId

there won't be the comment (commentId), so after reload the pad the comment won't be shown.
Is that the consciously behavior? Does anyone know a way / fix to save comments on read-only pads?
</issue_description>

Comments on the Issue (you are @copilot in this section)

@JohnMcLear You can already comment in a read only pad afaik. @JohnMcLear Or is it you can see them but not reply? @JohnMcLear I swear I added support for this.. Did you checkout latest version? @JohnMcLear Mheh, will take a look tonight or tomorrow. @JohnMcLear https://github.com//pull/39 @JohnMcLear I'm not gonna get time to look at this now until Late August, apologies! @JohnMcLear Just allow comments through as an allowed message type and add the comments container to the read only view. @JohnMcLear @gulaschskanone I'm available as a gun for hire if you want to get this done sooner than I get spare time? @JohnMcLear @thmo it's probably not a huge job to fix, assuming this is for a commercial project did you want to setup a bounty so we can get more eyes on it else it's gonna just fall naturally on our roadmap. @JohnMcLear Ah okies, well when we're doing our next big push on ep_comments we will try address these bugs. Fair point RE the security issue, that should be getting rejected! @JohnMcLear Take a stab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

comment in a read-only Pad?

2 participants