Polyhedron Constructor silently fails with non existing file locations

[metric-space]

Hello hello

Thank you for open sourcing this work

I believe I have stumbled upon a bug

Constructor silently fails if non existing file/file locations are given in with valid file suffixes (with the right count i.e 2).

What I mean by by silently fails (please see code below) is eros_polyhedron.vertices pops out an empty list

from polyhedral_gravity import Polyhedron, evaluate, PolyhedronIntegrity, NormalOrientation, GravityEvaluable, MetricUnit


eros_vertices_path = "./absolutely_made_up_data/Eros.node"
eros_faces_path = "./ata/Eros.face"
density = 2670.0

eros_polyhedron = Polyhedron(
    polyhedral_source=[eros_vertices_path, eros_faces_path],
    density=density,
    normal_orientation=NormalOrientation.OUTWARDS,
    integrity_check=PolyhedronIntegrity.VERIFY,
    metric_unit=MetricUnit.UNITLESS,
)

I think if you trace it all the way, you end up here: https://github.com/libigl/tetgen/blob/master/tetgen.cxx#L367
(from here: https://github.com/esa/polyhedral-gravity-model/blob/main/src/polyhedralGravity/input/TetgenAdapter.cpp#L40)

I can write a fix if you folks don't have the time

[schuhmaj]

Hi @metric-space,

Thank you for using our implementation and opening up this issue. I am sorry for the late reply; the year has been quite busy.

The fix is now finally on its way in #50 and will be in the release version 3.3.1.