Skip to content

add vst3 ui snapshots - #12

Merged
erikgrahn13 merged 1 commit into
mainfrom
codex/add-vst3-ui-snapshots
Jul 29, 2026
Merged

add vst3 ui snapshots#12
erikgrahn13 merged 1 commit into
mainfrom
codex/add-vst3-ui-snapshots

Conversation

@erikgrahn13

Copy link
Copy Markdown
Owner

Summary

  • add SNAPSHOT and SNAPSHOT_2X options to singularity_configure_vst3
  • generate the processor-CID filenames required by VST3 hosts
  • package the generated images with smtg_target_add_plugin_snapshots
  • demonstrate the feature in ExampleEffect and document the public CMake API

Why

VST3 snapshot discovery requires filenames to start with the processor class ID. Singularity generates processor IDs internally, so this keeps that VST3-specific naming detail out of plugin projects while retaining a minimal opt-in API.

Implements the VST3 UI snapshots backlog item.

Validation

  • Debug configure completed successfully
  • ExampleEffect_VST3 Debug target built and packaged the CID-named snapshot
  • Release VST3 validator discovered the snapshot and passed all 47 tests
  • git diff --check passed

Tested on macOS.

@erikgrahn13
erikgrahn13 marked this pull request as ready for review July 29, 2026 16:44
@erikgrahn13
erikgrahn13 merged commit dede56b into main Jul 29, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24638de188

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +210 to +212
if(NOT VST3_CONFIG_SUBCATEGORIES
AND NOT VST3_CONFIG_SNAPSHOT
AND NOT VST3_CONFIG_SNAPSHOT_2X)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require the base snapshot before accepting the 2× variant

When a caller supplies only SNAPSHOT_2X, this condition treats the configuration as valid and packages only <cid>_snapshot_2.0x.png. The documented high-resolution image is an optional variant of SNAPSHOT; without <cid>_snapshot.png, hosts that request the standard-resolution filename will show no preview. Reject SNAPSHOT_2X unless SNAPSHOT is also provided.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant