add vst3 ui snapshots - #12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24638de188
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(NOT VST3_CONFIG_SUBCATEGORIES | ||
| AND NOT VST3_CONFIG_SNAPSHOT | ||
| AND NOT VST3_CONFIG_SNAPSHOT_2X) |
There was a problem hiding this comment.
Require the base snapshot before accepting the 2× variant
When a caller supplies only SNAPSHOT_2X, this condition treats the configuration as valid and packages only <cid>_snapshot_2.0x.png. The documented high-resolution image is an optional variant of SNAPSHOT; without <cid>_snapshot.png, hosts that request the standard-resolution filename will show no preview. Reject SNAPSHOT_2X unless SNAPSHOT is also provided.
Useful? React with 👍 / 👎.
Summary
SNAPSHOTandSNAPSHOT_2Xoptions tosingularity_configure_vst3smtg_target_add_plugin_snapshotsExampleEffectand document the public CMake APIWhy
VST3 snapshot discovery requires filenames to start with the processor class ID. Singularity generates processor IDs internally, so this keeps that VST3-specific naming detail out of plugin projects while retaining a minimal opt-in API.
Implements the VST3 UI snapshots backlog item.
Validation
ExampleEffect_VST3Debug target built and packaged the CID-named snapshotgit diff --checkpassedTested on macOS.