Simplify Priority 1 APIs around functions - #10
Merged
Merged
Conversation
Introduce immutable LocalFrame, PlanarGeometry, and TriGeometry types with explicit WGS84 ENU projection provenance, validated named parameters, geographic/local conversions, and expert array views.
Let Fault.planar consume PlanarGeometry, let triangular factories consume TriGeometry, and retain LocalFrame provenance across Fault, Mesh, and medium copies while preserving legacy scalar and reference-origin calls.
Accept PlanarGeometry in geometry search and rectangular Bayesian inference, return named geometry results, accept TriGeometry in TriWarp, and propagate LocalFrame through triangular kernels, caches, plotting, exports, and explicit frame transforms.
Add the geometry reference, replace beginner-facing theta examples with named geometry, document explicit projection and frame transforms, close Priority 1.1, and record plate-rake/Euler-pole slip coordinates for Priority 1.2.
Keep classes for durable state and prepared computations while replacing transient wrappers and planned configuration facades with module functions.
Use array packing and basis-conversion functions, restore the three-array displacement return, and expose physical slip directly on inversion results.
Keep LocalFrame for coordinate identity, move parameter and triangle conversions to functions, and return Fault from geometry inference.
Use specific module functions and a two-release invert-to-solve transition without a callable module proxy.
Make geodef.invert the module, expose solve as the inversion entry point, and give Green's matrix operations concise public names. Add regression coverage for the final namespace shape without a compatibility shim.
Update the roadmap, reference docs, tutorials, and examples to use invert.solve and greens.matrix directly. Record Priority 1.2 as complete without a deprecation cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation