Skip to content

Up the max num of batches to 10#13550

Open
eqbech wants to merge 1 commit into
mainfrom
change-default-num-batches-to-plot
Open

Up the max num of batches to 10#13550
eqbech wants to merge 1 commit into
mainfrom
change-default-num-batches-to-plot

Conversation

@eqbech
Copy link
Copy Markdown
Contributor

@eqbech eqbech commented May 12, 2026

Issue
Resolves #13459

@berland
Copy link
Copy Markdown
Contributor

berland commented May 12, 2026

This also affects Ert, in that you can now plot up to 10 ensembles at the same time. This makes sense, but implies that the commit message can mention ensembles instead of or in addition to batches.

@eilskra
Copy link
Copy Markdown
Contributor

eilskra commented May 12, 2026

It should be conditional based on plot type. We don't want 10 batches pre-selected for some plots, e.g with summary data, ref #13458

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (8d253e0) to head (0024ed5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13550      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.02%     
==========================================
  Files         460      460              
  Lines       32519    32519              
==========================================
- Hits        29150    29146       -4     
- Misses       3369     3373       +4     
Flag Coverage Δ
cli-tests 37.01% <0.00%> (ø)
fuzz 43.97% <100.00%> (ø)
gui-tests 63.70% <100.00%> (-0.01%) ⬇️
performance-and-unit-tests 78.03% <100.00%> (-0.01%) ⬇️
test 45.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t/gui/tools/plot/plot_ensemble_selection_widget.py 89.28% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

objective_function_plot should default to all selected and plot all batches

4 participants