Save observation scaling factors to target ensemble#13441
Open
frode-aarstad wants to merge 4 commits into
Conversation
frode-aarstad
force-pushed
the
13348-auto_scaling-saves-observation_scaling_factors-to-source-ensemble-instead-of-target-ensemble
branch
from
1fa7752 to
cc659c1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13441 +/- ##
==========================================
- Coverage 89.98% 85.36% -4.63%
==========================================
Files 457 459 +2
Lines 31702 32087 +385
==========================================
- Hits 28528 27390 -1138
- Misses 3174 4697 +1523
Flags with carried forward coverage won't be shown. Click here to find out more.
|
erlenlh
reviewed
Apr 29, 2026
|
|
||
| experiment = storage.create_experiment(name="dummyexp") | ||
| ensemble = experiment.create_ensemble(name="dummy", ensemble_size=10) | ||
| source_ensemble = experiment.create_ensemble(name="dummy", ensemble_size=10) |
Contributor
There was a problem hiding this comment.
maybe name="dummy_source" to keep in line with all the outher ensemble names? same for the other dummies in this file
Contributor
Author
|
Might also need a storage migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #13348
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable