Crown quote-table rows per lane, not per direction - #177
Merged
Conversation
The miner header crowned every row of a direction the miner held on any lane, so a tao-lane sol<->tao crown also gilded the sol-bond row. Key the crown check on (direction, backing) via das currentCrownLanes; fall back to the old per-direction behaviour when an older das omits the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the miner detail page, UID 189 showed a crown on both the native SOL/TAO row and the `TAO BOND` row, while UID 56 also showed sol↔tao crowns. Live `/crown`: 189 holds the tao-backed lane, 56 the sol-backed lane. The quote table matched crowns on direction alone (`crownSet.has("SOL-TAO")`), so the lane distinction was lost.
Change
The header badge (`SOL→TAO TAO→SOL`) is unchanged — still true for both miners, just lane-agnostic.
Depends on: entrius/das-allways#112 (degrades gracefully without it).