NCF compras - #45
Open
NB5055 wants to merge 2 commits into
Open
NCF compras#45NB5055 wants to merge 2 commits into
NB5055 wants to merge 2 commits into
Conversation
Correccion de validacion NCF compras
gustavovalverde
requested changes
Oct 15, 2017
gustavovalverde
left a comment
gustavovalverde
left a comment
Collaborator
There was a problem hiding this comment.
Verificar los comentarios, tambuén validar si tal vez sería más conveniente hacer una condición como esta:
res = self.env["marcos.api.tools"].invoice_ncf_validation(rec)
if res is not True:
raise exceptions.ValidationError(res[2])
| elif rec.type in ( | ||
| "in_invoice", "in_refund") and rec.journal_id.purchase_type == "normal" and rec.partner_id.vat: | ||
| ncf_validation_result = self.env["marcos.api.tools"].invoice_ncf_validation(self) | ||
| if ncf_validation_result != True: |
Collaborator
There was a problem hiding this comment.
Mejorar sintaxis de la condición pythonif ncf_validation_result is not True
| msg = u"El proveedor no tiene RNC y es requerido para este tipo de compra." | ||
|
|
||
| elif rec.type in ( | ||
| "in_invoice", "in_refund") and rec.journal_id.purchase_type == "normal" and rec.partner_id.vat: |
Collaborator
There was a problem hiding this comment.
No solo son los normales, también los informales
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correccion de validacion NCF compras