Repository navigation
feat: verify generic ZIP containers - #41
Merged
Merged
Conversation
…ip-based) The ZIP collection-hash verifier already handled any ZIP; only the MIME tables left generic ZIP out. Both MIME types now map to the ZIP path and appear in supportedMimeTypes; .zip and .sketch are inferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken invariant: our signer produces generic ZIP (and .sketch) files with a c2pa.hash.collection.data binding, and the ZIP collection-hash verifier handles them, but the MIME tables omitted application/zip and application/x-zip-based, so verify refused them as unsupported.
Fix: map both MIME types to the ZIP path and advertise them; infer .zip and .sketch.
Proof: tests/generic_zip.rs (signed match / member-tamper mismatch under both MIME types), scripts/test-wasm.mjs (same in WASM), cargo test -p encypher-c2pa (977), clippy, public surface unchanged (405).