Repository navigation
Fix LLM rules setup and update LLM instructions - #2623
Merged
Merged
Conversation
CLI: - Don't panic when the daemon fails to create the app (nil appResp). - Skip downloading instructions when no tool is selected. - Check the HTTP status and set a timeout when downloading, so error pages are never written as rule files. - Fetch instructions from the CLI's release tag, falling back to main, so they only describe commands and MCP tools that version has. - Parse JSONC editor configs (.vscode/mcp.json, .zed/settings.json). - Don't write a VS Code MCP config with an empty --app. Instructions: - Remove wait_for_subscription_message and retry_until, reverted in #2460. - Make the MCP section editor-agnostic; the same text is installed for Cursor, VS Code, Zed and AGENTS.md, not only Claude Code. - Add an Encore Cloud access section: CLI login and Cloud MCP setup/auth. - Fix invalid code samples and wrong claims in the TS and Go files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs in
encore app create/encore llm-rules initrule generation and in the TS/Go LLM instructions they install (AGENTS.md,.claude/CLAUDE.md, Cursor, Copilot, Zed).CLI (
llm_rules/tool.go,app/create.go)createAppreadappResp.AppIdafterdaemon.CreateAppfailed (nil pointer). Now usesGetAppId().refs/tags/<version>and fall back tomain, so instructions only describe tools/commands that CLI has. Trade-off: content fixes reach a CLI only from the next release on..vscode/mcp.jsonand.zed/settings.jsonare parsed with hujson instead of failing on comments. Comments are still dropped on rewrite.--app=.Instructions (both files)
wait_for_subscription_messageandcall_endpoint'sretry_until. Both were reverted in Revert "cli/daemon/mcp: synchronous Pub/Sub probe + retry-aware call_endpoint" #2460 but were still advertised..mcp.json/mcp__encore-local__/Glob/Grep/Read, drops the wrong "20 tools" count (18 on main) and the dangling "When NOT to use it" reference.whoamicheck, ask the user to runauth login,ENCORE_AUTH_KEYfor CI.TS fixes
getTodoTitlewasasyncwithout aPromisereturn type, and itsqueryRowhad no row generic.et.Topictip.https:///URL and browser-onlycredentials.require("apollo-server"); now imports@apollo/server.hello.test.tsnaming, missingServiceimport, Node 22+,--auth-keyremoved from the CLI reference.Go fixes
encore.appis JSON, not CUE.type FooBar struct.clusterin the cache example.//encore:service.--typeflags. The SDK is left on v1 to matchencoredev/examples/clerk.Testing
go build,go vetandgo test ./cli/cmd/encore/app/pass..vscodewithout an app slug, and that a 404 returns an error.Need help on this PR? Tag
@codesmith-botwith what you need.