feat(sessions): add delete command and enrich sessions list - #19
Merged
emretheus merged 2 commits intoJun 8, 2026
Merged
Conversation
- Add delete_session() to inclave_core with CLIError on missing name - Export SessionSummary dataclass from inclave_core (name, saved_at, model, turns, file_count) - list_sessions() now returns List[SessionSummary] instead of tuples - inclave sessions list table now shows model, turn count, and file count columns - inclave sessions delete <name> command with --yes/-y to skip confirmation - 6 new tests covering delete, delete-missing error, rich list fields, and list-after-delete https://claude.ai/code/session_01M8pedejYy92FrrdGjVksEt
emretheus
added a commit
that referenced
this pull request
Jun 8, 2026
The PR #19 merge dropped the upper half of sessions.py (imports, Session, save_session, load_session), which broke test collection repo-wide with a NameError. Restore it from the last good revision. delete_session also had a contradictory contract: the implementation returned Path and raised on a missing file, while the bridge handler and the newer tests expect a bool (True if removed, False if absent). Align the implementation with that contract and drop the stale test that asserted the raise behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Checklist
uv run ruff check . && uv run ruff format --check .is cleanuv run mypy packages sharedis cleanuv run pytest --covis clean (≥75% coverage)api.py), it has reviewers from each affected package