BackgroundManager: Defer to user preference when translucent - #701
Open
danirabbit wants to merge 9 commits into
Open
BackgroundManager: Defer to user preference when translucent#701danirabbit wants to merge 9 commits into
danirabbit wants to merge 9 commits into
Conversation
danirabbit
changed the title
danirabbit
marked this pull request as ready for review
August 28, 2026 00:10
danirabbit
commented
Aug 28, 2026
|
|
||
| update_panel_dimensions (); | ||
| Services.BackgroundManager.initialize (panel_height); | ||
| Services.BackgroundManager.initialize (panel.get_height ().clamp (16, 48)); |
Member
Author
There was a problem hiding this comment.
I guess this is a workaround, but it fixes the transparent behavior 🤷♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #657
Follow the user preference when the panel will be translucent.
If Gala thinks the panel should be transparent, reduce transparency makes it translucent:
if Gala thinks the panel should be translucent, reduce transparency makes it completely opaque
If Gala thinks the panel should be transparent, maintain the current behavior:
Note: This should theoretically use Granite.StyleManager, but it's not sending correct color info rn