fix: demote log message for failing to query APM server version from 'error' to 'debug' - #794
Merged
kruskall merged 1 commit intoOct 1, 2026
Conversation
…'error' to 'debug' For fast Lambda functions and a comparatively slow APM server response time, it is relatively common for a Lambda cold start to hit the 'Error querying version from the APM server' case: the Lambda function starts, the APM agent sends a version info request to APM server, the Lambda function completes, the Lambda instance is frozen, the request to APM server times-out, the Lambda instance is unfrozen for a subsequent invocation, the version info request fails. It is misleading to the user to log at *error* level for this. Typically the APM agent will fallback to reasonable handling if it cannot determine the APM server version. And if not, it is up to the APM *agent*, not the proxying APM Lambda extension, to log at a higher level if necessary.
Contributor
🤖 GitHub commentsJust comment with:
|
jackshirazi
approved these changes
Sep 29, 2026
dmathieu
approved these changes
Sep 30, 2026
kruskall
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fast Lambda functions and a comparatively slow APM server response time,
it is relatively common for a Lambda cold start to hit the
'Error querying version from the APM server' case: the Lambda function
starts, the APM agent sends a version info request to APM server,
the Lambda function completes, the Lambda instance is frozen,
the request to APM server times-out, the Lambda instance is unfrozen for
a subsequent invocation, the version info request fails.
It is misleading to the user to log at error level for this.
Typically the APM agent will fallback to reasonable handling if it
cannot determine the APM server version. And if not, it is up to
the APM agent, not the proxying APM Lambda extension, to log
at a higher level if necessary.