fix: deduplicate custom_logo insert in logo_slot at runtime#22
Merged
Conversation
The _add_themed_logo hook adds a custom_logo insert for every MFE, which can result in duplicate entries in the generated env.config.jsx, causing the logo to render twice. Add a runtime deduplication check that keeps only the first custom_logo insert, mirroring the existing footer slot dedup logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
quick-deploy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_logoinsert plugins inlogo_slotat runtime_add_themed_logohook adds acustom_logoinsert for every MFE, which can result in duplicate entries inenv.config.jsxmfe-env-config-runtime-finalthat keeps only the firstcustom_logoinsert, mirroring the existing footer slot dedup logicTest plan
deployorquick-deploycommentenv.config.jsxin the MFE container to confirmlogo_slothas a singlecustom_logoinsert🤖 Generated with Claude Code