fix: prevent duplicate logo in MFE header#19
Merged
Conversation
…ult content The _add_themed_logo function inserts ThemedLogo into logo_slot for all MFEs, but addPlugins() hardcodes keepDefault: true, which causes the default brand logo to render alongside ThemedLogo — showing the FBR logo twice side by side. Set keepDefault: false for logo_slot in mfe-env-config-runtime-final so only ThemedLogo renders in the slot, matching the same pattern used for the footer deduplication fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
arbirali
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_add_themed_logoinsertsThemedLogointologo_slotfor all MFEs, butaddPlugins()hardcodeskeepDefault: true, causing the default brand logo to render alongsideThemedLogokeepDefault: falseforlogo_slotinmfe-env-config-runtime-final, so onlyThemedLogorenders — same pattern as the existing footer deduplication fix in that fileTest plan
🤖 Generated with Claude Code