fix(studio-header): prevent course title truncation caused by oversized logo#65
Merged
Waleed-Mujahid merged 1 commit intoJun 15, 2026
Conversation
Waleed-Mujahid
force-pushed
the
fix/EDLYPRODUCT-8294-studio-header-title
branch
from
408cb4b to
5fe1797
Compare
arbirali
approved these changes
Jun 12, 2026
Abdul-Muqadim-Arbisoft
requested changes
Jun 12, 2026
Abdul-Muqadim-Arbisoft
left a comment
Abdul-Muqadim-Arbisoft
left a comment
There was a problem hiding this comment.
max-width is in px while the existing height is in rem, can we put max-width as rem as well for consistency?
…ed logo PR #53 increased the studio header logo height from the upstream default of 1.75rem to 3rem to support adaptive logo sizing across different dimensions. The upstream frontend-component-header wraps the logo and course title lockup in a flex container where the logo area uses the Bootstrap utility class w-25. At 1.75rem the logo fits comfortably within that 25% allocation; at 3rem it does not, causing the course org/number/title to be squeezed to a few pixels and rendered as an ellipsis. Widen the w-25 wrapper to 40% scoped to .studio-header to give the taller logo room without affecting Bootstrap utility usage elsewhere. Add max-width and object-fit on .logo as a safeguard against wide SVG logos expanding horizontally at the increased height.
Waleed-Mujahid
force-pushed
the
fix/EDLYPRODUCT-8294-studio-header-title
branch
from
5fe1797 to
5a13e61
Compare
Member
Author
Updated and tested. Kindly re-review |
arbirali
pushed a commit
that referenced
this pull request
Jul 2, 2026
…r-title fix(studio-header): prevent course title truncation caused by oversized logo
arbirali
pushed a commit
that referenced
this pull request
Jul 2, 2026
…r-title fix(studio-header): prevent course title truncation caused by oversized logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #53 increased the studio header logo height from 1.75rem to 3rem for adaptive logo sizing. The upstream
frontend-component-headerwraps the logo and course title lockup in a flex row where the logo side uses Bootstrap utility.w-25(25% width). At 3rem the logo overflows its 25% allocation, squeezing the course org/number/title to a few pixels — everything renders as....Fix
.studio-header .w-25 { width: 40% !important; }— widens the wrapper from 25% to 40% scoped to studio header only.!importantrequired because Bootstrap ships.w-25 { width: 25% !important }..logo { max-width: 10rem; object-fit: contain }— prevents wide SVG logos from expanding horizontally at the increased height. Usesremto scale proportionally withheight: 3rem.Before
After