Bump RAVEN to 4ea9b09 and unskip the CHRR example - #36
Merged
Conversation
RAVEN 4ea9b09 carries the sampleCHRR fix (#696), so randomSampling(...,'chrr') no longer fails on smallYeast and the block in 15.3 can be executed and checked like every other example: 6 passed, 0 skipped. Its documented output is unchanged, which confirms what was captured against the patched clone. The note now reads as history rather than a caveat -- if a reader hits "flux polytope has empty interior", the answer is to update RAVEN. The bump also brings #693 (no Parallel Computing Toolbox required for gurobi; optional task-list columns) and #695 (docstring indentation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the RAVEN submodule
2282883→4ea9b09and removes the oneskipmarker in the user guide.
4ea9b09carries RAVEN#696,the
sampleCHRRfix, sorandomSampling(..., 'method', 'chrr')no longer dieson
smallYeastwithflux polytope has empty interior. The CHRR block in 15.3is therefore executed and checked like every other example:
Its documented output is unchanged — the text captured earlier against a
patched clone matches what the released RAVEN produces, warning line included.
The page's note becomes history rather than a caveat: if you hit that error, the
answer is to update RAVEN.
The bump also brings #693
(gurobi no longer requires the Parallel Computing Toolbox; optional task-list
columns) and #695 (docstring
indentation — a strict docs build now reports zero griffe warnings from RAVEN).
The guide has no skipped examples left in any language.