Skip to content

Anegm/fault models needs elements#657

Closed
ANegm-ETAS wants to merge 4 commits intoeclipse-score:mainfrom
etas-contrib:anegm/fault-models-needs-elements
Closed

Anegm/fault models needs elements#657
ANegm-ETAS wants to merge 4 commits intoeclipse-score:mainfrom
etas-contrib:anegm/fault-models-needs-elements

Conversation

@ANegm-ETAS
Copy link
Copy Markdown
Contributor

@ANegm-ETAS ANegm-ETAS commented Apr 14, 2026

  • Fault Models are now needs elements that can be linked to from the FMEA/DFA

  • Changed the format of the DFA and FMEA Fault Models to be represented as a table

  • added the following fields to the FMEA template:
    failure_root_cause
    safety_relevant

  • added the following fields to the DFA template:
    safety_relevant

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of the needs objects being decalred in process randomly in a conf.py

We should declare everything that isn't repo specific that only that repo needs in the metamodel.
And it seems if I understand correclty that FMEA and DFA are that way.

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description missing how to use the new attributes "safety_relevant" and "root cause" (i.e. reasoning why needed)
Unclear what the benefit is of having the dfa_failure_indicators and fault_models as needs elements.

- High
------------------------------------

.. fmea_fault_model:: message is not received
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the "fmea_fault_model" also be defined in the docs-as-code metamodel (if agreed)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In my opinion it should be.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created new PR here to add the "fmea_fault_model" to the docs-as-code
eclipse-score/docs-as-code#499

* - SC_01_05
- Development fault (e.g. human error, insufficient qualification, insufficient methods). Only applicable if diverse development is needed.
- Medium
.. dfa_failure_initiator:: Reused software components
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the "dfa_failure_initiator" also be defined in the docs-as-code metamodel (if agreed)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In my opinion it should be.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created new PR here to add the "dfa_failure_initiator" to the docs-as-code
eclipse-score/docs-as-code#499

@ANegm-ETAS ANegm-ETAS force-pushed the anegm/fault-models-needs-elements branch from eac644e to b4354a7 Compare April 17, 2026 10:58
@ANegm-ETAS
Copy link
Copy Markdown
Contributor Author

Description missing how to use the new attributes "safety_relevant" and "root cause" (i.e. reasoning why needed) Unclear what the benefit is of having the dfa_failure_indicators and fault_models as needs elements.

  • since failures discovered in FMEA/DFA might not necessarily be safety relevant the field "safety_relevant" should indicate the criticality of the failure , and "root cause" field is needed since in the current layout doesn't make it clear what actually caused the failure and makes it difficult to actually review if the mitigation method addresses the failure root cause

  • having the dfa_failure_indicators and fault_models as needs elements enables us to link to the fault models from the FMEA

@ANegm-ETAS
Copy link
Copy Markdown
Contributor Author

according to discussion in S-CORE Safety Team Process Community
https://github.com/orgs/eclipse-score/discussions/2234?sort=new#discussioncomment-16582708

The entire list of Fault Modes will be copied into each component/feature/platform FMEA/DFA so from a process point of view we do not need to create needs elements of fault modes to link them to the safety analysis

@ANegm-ETAS ANegm-ETAS closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants