Fix the pip requirements setup#176
Open
NicolasFussberger wants to merge 2 commits intoeclipse-score:mainfrom
Open
Fix the pip requirements setup#176NicolasFussberger wants to merge 2 commits intoeclipse-score:mainfrom
NicolasFussberger wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
NicolasFussberger
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
PiotrKorkus
requested changes
Apr 28, 2026
Contributor
PiotrKorkus
left a comment
PiotrKorkus
left a comment
There was a problem hiding this comment.
The current solution was partially correct. The only thing that needs fixing is that compile_pip_requirements generates file requirements.lock that this PR is removing and in your MODULE pip is parsing requirements_lock.txt which is incorrect.
- Keep
requirements.lock - update
tests/integration/requirements.txtwith current deps - Run
bazel run //tests/integration:requirements.update - Remove
requirements_lock.txtfrom repo root - Replace in MODULE file in pip.parse command:
requirements_lock = "//tests/integration:requirements.lock",
Comment on lines
-23
to
36
| compile_pip_requirements( | ||
| name = "requirements", | ||
| srcs = [ | ||
| "requirements.txt", | ||
| "@score_tooling//python_basics:requirements.txt", | ||
| ], | ||
| extra_args = [ | ||
| "--no-annotate", | ||
| ], | ||
| requirements_txt = "requirements.lock", | ||
| tags = [ | ||
| "manual", | ||
| ], | ||
| filegroup( | ||
| name = "pip_requirements", | ||
| srcs = ["requirements.txt"], | ||
| visibility = ["//:__pkg__"], | ||
| ) |
Contributor
There was a problem hiding this comment.
usage of compile_pip_requirements is correct.
There should be two requirements files in repository. One with list of libraries that is the input to this command and one lock file generated by this command.
In MODULE file there is pip parse of the requirements lock.
Please take a look at the setup in reference_integration - this is corerct.
- MODULE file: https://github.com/eclipse-score/reference_integration/blob/3c843821b8e055372e87ea3aff6ac84b53e903ea/bazel_common/score_python.MODULE.bazel#L33
- requirements.in: https://github.com/eclipse-score/reference_integration/blob/main/scripts/tooling/requirements.in
- requirements.txt (lockfile): https://github.com/eclipse-score/reference_integration/blob/main/scripts/tooling/requirements.txt
- BUILD file for the compile reqs: https://github.com/eclipse-score/reference_integration/blob/3c843821b8e055372e87ea3aff6ac84b53e903ea/scripts/tooling/BUILD#L24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the way that python requirements are used:
bazel run //:requirements.updateto update the lockfile