Apply fixes from PR 664 - #665
Open
mbarbero wants to merge 2 commits into
Open
Conversation
…#663) Manage GitHub immutable release settings at both repository and organization level, including selected repository enforcement. Coerce repo settings against org policy during diff/apply and add schema, docs and test updates for the new configuration fields. Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
Distinguish 404 (feature not enabled) from genuine errors (5xx, 403) in _fill_immutable_releases, and gracefully degrade when the org-level immutable releases endpoint returns 404 instead of raising RuntimeError. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Mikaël Barbero <mikael.barbero@eclipse-foundation.org>
There was a problem hiding this comment.
Pull request overview
This PR incorporates follow-up fixes from #664 and completes support for GitHub “immutable releases” at both repository and organization settings levels, including provider/client behavior, model coercion/validation, schemas, docs, and tests.
Changes:
- Add repo-level immutable releases read/update support in the REST repo client and cover rename + post-update ordering in tests.
- Add org-level immutable releases policy read/update support in the REST org client, including selected-repository enforcement support and tests.
- Extend models/schemas/docs to include new configuration keys and ensure org policy coercion/validation is reflected in diffs/live patches.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/providers/github/rest/test_repo_client.py | Adds tests for repo immutable releases fill behavior and update ordering when repo is renamed. |
| tests/providers/github/rest/test_org_client.py | Adds tests for org immutable releases policy retrieval, updates, and 404 fallback behavior. |
| tests/models/test_repository.py | Updates repository model tests to include immutable_releases_enabled and provider payload size. |
| tests/models/test_org_settings.py | Updates org settings model tests to include immutable releases policy fields and provider payload size. |
| tests/models/resources/otterdog-repo.json | Adds immutable_releases_enabled to model fixture data. |
| tests/models/resources/otterdog-org-settings.json | Adds immutable releases policy fields to model fixture data. |
| tests/models/resources/github-repo.json | Adds immutable_releases_enabled to provider fixture data. |
| tests/models/resources/github-org-settings.json | Adds immutable releases policy fields to provider fixture data. |
| otterdog/resources/schemas/settings.json | Extends org settings schema with immutable releases policy fields. |
| otterdog/resources/schemas/repository.json | Extends repository schema with immutable_releases_enabled. |
| otterdog/providers/github/rest/repo_client.py | Implements repo immutable releases fill/update and wires it into repo data retrieval/update/apply flow. |
| otterdog/providers/github/rest/org_client.py | Implements org immutable releases policy retrieval and update endpoints integration. |
| otterdog/models/repository.py | Adds repository field + org-policy coercion/validation and live-patch handling for immutable releases. |
| otterdog/models/organization_settings.py | Adds org settings fields + diff/validation rules for immutable releases policy fields. |
| docs/userguide/unsupported.md | Fixes/clarifies a bullet in the unsupported features list. |
| docs/reference/organization/settings.md | Documents new org-level immutable releases settings and validation warning behavior. |
| docs/reference/organization/repository/index.md | Documents new repo-level immutable_releases_enabled field and its interaction with org policy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+91
to
+95
| immutable_releases_enforced_repositories = data.pop("immutable_releases_enforced_repositories", None) | ||
| immutable_releases_selected_repositories = data.pop("immutable_releases_selected_repositories", None) | ||
|
|
||
| try: | ||
| await self.requester.request_json("PATCH", f"/orgs/{org_id}", data) | ||
| if len(data) > 0: |
|
@mbarbero @kairoaraujo what's your release cycle? I've pushed the initial code changes > 1 month ago |
Contributor
Author
|
The release cycle is currently chaotic due to conflicting priorities. We will merge and deploy the changes as soon as possible. We appreciate your patience. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #664, with additional fix commits.