Don't set focus on preference page creation - #1326
Open
nitind wants to merge 2 commits into
Open
Conversation
donat
self-requested a review
March 11, 2025 08:47
donat
requested changes
Mar 11, 2025
donat
left a comment
donat
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contribution!
I have one request before I can merge your changes. I'd be happy discuss that separately.
| for (Button radioButton : allRadioButtons) { | ||
| if (radioButton.equals(selectedRadioButton)) { | ||
| radioButton.setSelection(true); | ||
| radioButton.setFocus(); |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <classpath> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11"/> |
Contributor
There was a problem hiding this comment.
The intent here with not specifying the version was to allow the active target definition to select the Java version. That way, we can always select the lowest required java version for a given Eclipse platform version.
❌ This change should not be part of this PR.
Author
There was a problem hiding this comment.
I disagree with the reasoning, but I've removed this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1204, and properly refers to BREE JRE