Date filter annual datasets

[liviajakob]

🚀 Type of Change

• ✨ New feature
• 🐞 Bug fix
• 📝 Documentation update
• ♻️ Refactor / code cleanup
• ⚙️ Dependency upgrade
• 🚢 CI update

📝 Description

Quick change to filter annual datasets to the date range specified in the configs before combining.
This is now needed as in GlaMBIE-2 some datasets go far back into the past.

Also did some renaming of terminology in the output plots from Consensus to Reconciled.

🐝 Hive Card

https://app.hive.com/workspace/GNxP5GYvPWRvyG2Cr?actionId=zfSvkDMN4t8stdys6

✅ Checklist

• My code follows the project’s style and guidelines.
• I have considered whether adding any Jupyter notebooks is necessary and useful to others.
  (Reminder: notebooks are brittle since they are not covered by automated tests.)
• I have considered the wider impact of changing shared components/libraries.
• I have tested my changes locally.
• I have updated relevant documentation (README, docs, comments).

📸 Screenshots (if applicable)

[Copilot]

Pull request overview

Adds support for clipping annual-trend datasets to a configured date window before downstream combination steps, ensuring outputs respect the run’s configured start/end years.

Changes:

• Added an output_date_range option to convert_datasets_to_annual_trends and applied it during regional annual-variability processing.
• Renamed regional-processing configuration plumbing from desired_time_span / *_for_longterm_trends to a unified min_max_time_window.
• Updated plot labels and the “consensus” data-group description to use “Reconciled/Reconciliation” wording, and added a unit test for date-range clipping.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/processing/test_processing_helpers.py	Adds a test asserting annual-trend outputs are clipped to a requested date range.
glambie/processing/processing_helpers.py	Introduces output_date_range clipping after annual-trend conversion.
glambie/processing/process_regional_results.py	Threads min_max_time_window through processing and applies annual clipping with a buffer for variability.
glambie/plot/processing_plots.py	Renames plot legend labels from “Consensus” to “Reconciled”.
glambie/const/data_groups.py	Updates the long name of the consensus data group to “Reconciliation…”.

Suppressed comments (1)

glambie/processing/process_regional_results.py:657

• min_max_time_window is declared optional (defaults to None), but this call unconditionally indexes it when building output_date_range, which will raise a TypeError if the function is used without a time window. Make the clipping conditional and pass None through when no window is provided.

        year_type=year_type,
        method_to_correct_seasonally=method_to_correct_seasonally,
        seasonal_calibration_dataset=seasonal_calibration_dataset,
        rgi_area_version=rgi_area_version,
        output_date_range=[min_max_time_window[0] - 1, min_max_time_window[1] + 1],

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mattkernow]

Looks good to go 👍🏻