chore: remove spot - #2117
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lukabuz
approved these changes
Jul 29, 2026
jaredvu
reviewed
Jul 29, 2026
Collaborator
There was a problem hiding this comment.
does mobile pull from the https://dydx.trade/configs/v1/env.json url?
jaredvu
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the /spot pages, the spotApi client, the bonsai spot form/rest/websocket/selectors, the
spot/spotForm/spotTrades slices, the TradingView spot datafeed, useEnableSpot, the SpotTrade
notification, the spot analytics events, and the spotApi entries in env.json.
Three things I left alone on purpose:
ComplianceStates.SPOT_ONLYstays. It's set bygeo.isPerpetualsGeoBlocked, not by the spotfeature, so removing it would drop geo blocked users through to FULL_ACCESS. The name is
misleading now but that's a separate rename.
screen and the SolanaAddress analytics property.
spotTradesfalls out of localStorage on its own once it's off thewhitelist, and the two leftover appUiConfigs keys are dead data nothing reads.
One behavior change worth a look: the deposit dialogs used to send non FULL_ACCESS users to the
spot tab. With no spot tab they now just close, which keeps CLOSE_ONLY users out of perps
deposits the same as before.
Users with a leftover spot balance can recover it by importing their dYdX secret phrase into Phantom.