fix: delay pebble-ready with background wait#54
Draft
dwilding wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how our
deploycommand works. We now kick off a background process that:The point of this change is to expose buggy integration tests that try to use the workload container too early in the charm's lifecycle. For example, the current version of k8s-3-postgresql is buggy in this way. The charm immediately blocks on the initial config-changed (because an integration is missing), then the integration tests move on to checking the workload version without requiring the workload container to be ready.
Test failures are expected until we fix the charms in Ops.