Navigate the UI with the controller: L1 shortcuts, modal buttons, Shortcuts tab - #275
Open
mathiasm74 wants to merge 8 commits into
Open
mathiasm74 wants to merge 8 commits into
mathiasm74 wants to merge 8 commits into
Conversation
…right of the tabs (cherry picked from commit 95810d4)
New L1 combos on the Calibration tab: - L1+square / L1+circle step through the display modes (Normal, 10x zoom, Check circularity) with no wrap-around; L1+circle while already on Check circularity clears the sampled data - L1+triangle runs the calibration dialogs in sequence: stick center, range, then finetune (skipped where unsupported), stopping if a step is cancelled - L1+cross saves pending changes, only when there are changes to write (mirrors the Save button's enabled state) The three calibration launchers are refactored into chainable runCenterCalibration/runRangeCalibration/runFinetune helpers shared by the buttons and the sequence. A new Shortcuts tab lists all L1 combos, using the PS button glyphs from icons.svg. New strings pending translation in lang/*.json. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 91c2ea2)
Pinned flush right with ms-auto, separating the reference tab from the work tabs. The Debug unlock click area and the VR2 tab hiding are unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit e829c10)
Cross, square and circle now work in the modals themselves: - Center calibration: cross starts/continues, square switches to quick calibrate, circle cancels - each only when the matching button is available, so calibration still can't be canceled mid-run. - Range calibration: cross clicks Done once it unlocks. The modal now consumes all controller input while open, so button presses no longer leak to the tab underneath. - Informational modals (popup, FAQ, donate, Edge notice, welcome): cross or circle dismisses; welcome records its acceptance as a click on Understood would. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit b95ab98)
The sampling itself cannot be interrupted, but pressing circle while the auto center calibration modal is up now stops an L1+triangle sequence from chaining into range calibration. The modal also swallows controller input while visible, like the other calibration modals. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 30e9960)
Cross still means Fail during a test; in the idle states (before starting, after the last test) it now mirrors circle and closes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 01e1987)
A left Sense controller carries L1 together with square and triangle, so L1+triangle would start the calibration sequence during normal use. Gate the combos off for VR2 and hide the Shortcuts tab via a new showShortcutsTab UI flag. Extracted from d69633e. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVo2fLzyxnPEJWordoQxwZ
Generated with scripts/process_lang.py --auto. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVo2fLzyxnPEJWordoQxwZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the PR changes
Lets the controller itself drive the UI, so a stick swap or calibration session doesn't need constant trips back to the mouse: