Error: Finetune data must be an array of 12 values, got "null" on new PS5 controller

[Szpytma]

Description

Got a new PS5 controller and received this error while trying to connect:

Error: Finetune data must be an array of 12 values, got "null"

Error Stack

Error: Finetune data must be an array of 12 values, got "null"
at lt.save (https://dualshock-tools.github.io/app-e424d901.js:1:117951)
at HIDDevice.mt (https://dualshock-tools.github.io/app-e424d901.js:1:131546)

Steps to Reproduce

1. Connect a new PS5 controller
2. Error appears immediately

Environment

• Controller: PS5 DualSense (new)

[Szpytma]

Additional info:

• My older PS5 DualSense controller works fine with the tool — this only happens with my new one.
• Browser: Chrome and Edge on Windows
• Controller model: DualSense

[Szpytma]

---

Fix: Handle null finetune data for new PS5 controllers

Fixes #222

Problem

When connecting a new PS5 DualSense controller, the app crashes with:

Error: Finetune data must be an array of 12 values, got "null"

getInMemoryModuleData() returns null when the HID response validation fails (new controllers may not have finetune
calibration data populated), but the callers don't check for null before using the data.

Changes

js/core.js (~line 371)

         const finetuneData = await controllerInstance.getInMemoryModuleData();
-        const serialNumber = await controllerInstance.getSerialNumber();
-        FinetuneHistory.save(finetuneData, serialNumber);
+        if (finetuneData) {
+          const serialNumber = await controllerInstance.getSerialNumber();
+          FinetuneHistory.save(finetuneData, serialNumber);
+        }

js/controllers/ds5-edge-controller.js (~line 131)

-      await this.writeFinetuneData(data);
+      if (data) {
+        await this.writeFinetuneData(data);
+      }

Why

Both changes add a null guard so the app gracefully skips instead of crashing when getInMemoryModuleData()
legitimately returns null (which all three controller implementations — ds5, ds5-edge, vr2 — can do when the HID
response doesn't match the expected format).

[Szpytma]

Ok, to be fair, the error that I got might be a potential flag for people to get some info that the pad is fake, as after checking it on ps5 it looks like there is no serial number assigned to the controller.

[carpikes]

Firmware build date "Jan 29 2034"? Seems a fake controller, can you post here a photo of the motherboard?

[Szpytma]

@carpikes Yeap it was fake one, pretty good one. So I guess it would be great to add an option for users to give an users info that the pad might be fake one. Lucky for me I managed to return it right away.

[pflugi2010-eng]

after i try to edit the core.js file i get the following error code in prompt:

[12:18:35] RollupError: js/core.js (379:4): Expected a semicolon
at getRollupError (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/parseAst.js:401:41)
at ParseError.initialise (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/node-entry.js:14463:28)
at convertNode (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/node-entry.js:16346:10)
at convertProgram (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/node-entry.js:15586:12)
at Module.setSource (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/node-entry.js:17341:24)
at async ModuleLoader.addModuleSource (file:///C:/Users/Pascal/Desktop/dualshock-tools.github.io-main/node_modules/rollup/dist/es/shared/node-entry.js:21354:13)
[12:18:35] 'build' errored after 32 ms

any help?

[carpikes]

Can you send here the full patch you applied?