feat: [CODE-5445]: propagate provider node_id into scm.Repository and scm.PullRequest#357
Open
anurag-harness wants to merge 1 commit into
Open
feat: [CODE-5445]: propagate provider node_id into scm.Repository and scm.PullRequest#357anurag-harness wants to merge 1 commit into
anurag-harness wants to merge 1 commit into
Conversation
… scm.PullRequest Adds a NodeID field to scm.Repository and scm.PullRequest and wires it through the GitHub, GitLab, and Bitbucket drivers so consumers see a provider-stable identifier alongside the existing numeric/UUID ID: - GitHub: maps the GraphQL node_id from REST payloads (Repository, PullRequest, and inline webhook converters: push, branch, tag, PR, deployment, issue comment, release). - GitLab: maps the project-scoped numeric id for repos and the global MR id (distinct from the project-scoped iid surfaced as Number) for PRs; applied across all webhook converters, including pipeline hooks where MergeRequest.ID is the canonical PR identifier. - Bitbucket: maps the repository UUID (already used for ID) and the PR numeric id (stringified) across REST and webhook flows. Updates ~60 testdata golden fixtures across the three drivers to include the new NodeID field. The change is purely additive. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
NodeIDfield toscm.Repositoryandscm.PullRequestand wires it through the GitHub, GitLab, and Bitbucket drivers so consumers receive a provider-stable identifier alongside the existing numeric/UUIDID.node_idfrom REST payloads viaconvertRepository/convertPullRequestand from all inline webhook converters (push, branch, tag, PR, deployment, issue comment, release). The PR review hook already routes throughconvertRepositoryso it picks the field up automatically.idfor repos, and the global MRid(distinct from the project-scopediidsurfaced asNumber) for PRs; applied across all webhook converters, including pipeline hooks whereMergeRequest.IDis the canonical PR identifier.uuid(already used forID) and the PR numericid(stringified) across REST and webhook flows, including push, branch/tag, PR, PR comment, and pipeline hooks.The change is purely additive — existing consumers see no behavior change. Downstream callers (e.g.
harness-core's SCM proto converters) will be updated in a follow-up to surfacenode_idinWebhookDTO.parsedResponse.Test plan
go test ./...(all driver suites + integration tests pass)go vet ./scm/...NodeIDfieldharness-corebuild once this is tagged as a pseudo-version🤖 Generated with Claude Code