Repository navigation
Conversation
|
Drive-by from someone who just hit this: this PR fixes a real correctness bug, which might be worth knowing when deciding whether to merge it.
I ran into it on a real migration set of 171 scripts, 42 of which use I verified the bump fixes it — with Apologies for the duplication: I opened #31 doing a subset of this before spotting #27. This PR is the better change — it drops One thing this PR doesn't cover, which I've raised separately: the |
Picks up the remaining version bumps proposed in drewburlingame#27 by @dreik - CommandDotNet, JetBrains.Annotations, YamlDotNet, System.Text.Encoding.CodePages, and the test packages - so this branch is a superset rather than a competing subset. FluentAssertions 8 renames BeLessOrEqualTo to BeLessThanOrEqualTo, which ContainerTest needed. Solution builds clean and all 111 unit tests pass on net8.0.
|
Following up on my comment above — I've folded your version sweep into #31/#32 rather than leaving them as a competing subset, so credit where it's due: the bumps there are your list, and I switched to your One thing worth flagging for this PR either way: it won't build on the .NET 10 SDK as it stands. Testcontainers 4.8.1 resolves It doesn't show up on the 8.0.x/9.0.x SDKs the workflows currently install, which is probably why it hasn't surfaced. Pinning Also, since this targets net10: the workflows only install |
subj