ABFS: fix NPE in getCaseInsensitiveEnum when fs.azure.fns.account.service.type is configured - #17
Open
neeraj-kulkarni wants to merge 3 commits into
Open
Conversation
getConfiguredServiceTypeForFNSAccounts() passed null as the defaultValue to getCaseInsensitiveEnum(). When fs.azure.fns.account.service.type IS configured, getCaseInsensitiveEnum calls defaultValue.getDeclaringClass() to resolve the enum type — NPE if defaultValue is null. Fix: pass getFsConfiguredServiceType() as the default, which is never null and matches the intent (fall back to the FS-level service type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getConfiguredServiceTypeForFNSAccounts()passednullas thedefaultValuetogetCaseInsensitiveEnum()fs.azure.fns.account.service.typeIS configured,getCaseInsensitiveEnumcallsdefaultValue.getDeclaringClass()to resolve the enum type — NPE ifdefaultValueis nullgetFsConfiguredServiceType()as the default, which is never null and semantically correct (fall back to the FS-level service type)Root cause
This bug was latent in the Hadoop 3.5.0 ABFS code — it only manifests when a caller sets
fs.azure.fns.account.service.typein the configuration. Dremio's WASB→ABFS shim (Prototype.initConf()) sets this key toBLOBfor flat-namespace accounts, which triggered the NPE.Test plan
fs.azure.fns.account.service.type=BLOBand verifygetConfiguredServiceTypeForFNSAccounts()returnsBLOBwithout NPE