Repository navigation
feat: enable color customisation of individual custom plugins - #402
Conversation
518ee9c to
43ca2e1
Compare
|
Added the forgotten |
|
This is very cool, and I've tested it with bash and python and it works well. Since users are still required to write I'd probably prefer to merge this without the suffix truncation, but I'm open to counterarguments. |
|
Glad you like it! |
|
Honestly, yes. would be more in line with |
|
Also, please adapt |
|
You're right, I forgot about scripts othen than bash. |
Assisted-by: Claude Code (Claude Sonnet 5, Claude Opus 5.5)
Nope, you're right and I'm just too tired. I'm sorry |
43ca2e1 to
6f90407
Compare
|
Ahah no problem :) Changes pushed, let me know if there's anything else. |
Theoreticallyhugo
left a comment
There was a problem hiding this comment.
There are two things I want to have acknowledged that these are "bugs" we don't need to fix. Just for future reference:
- The
custom-prefix avoids clashing, except when the custom plugin is calledplugin. In that case@dracula-custom-<name-of-script>-colorswould become the same as the old@dracula-custom-plugin-colors. - Scripts like
a[1].shcould fail as[1]is interpreted as array index.
I'd like to keep this PR open for at least another day, so that other people have the chance to veto me or your new changes. If nothing new comes up, we'll just merge.
Allow configuration of custom plugin colors as if they were dracula plugins.
For all
custom:<plugin-name>:@dracula-custom-<plugin-name>-colorsis checked@dracula-custom-plugin-colorsor dracula defaults ("cyan dark_dray")Assisted-by: Claude Code (Claude Sonnet 5, Claude Opus 5.5)