Skip to content

feat: enable color customisation of individual custom plugins - #402

Merged
Theoreticallyhugo merged 1 commit into
dracula:masterfrom
abourjac:custom-plugins-colors
Oct 14, 2026
Merged

Theoreticallyhugo merged 1 commit into
dracula:masterfrom
abourjac:custom-plugins-colors

Conversation

@abourjac

@abourjac abourjac commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Allow configuration of custom plugin colors as if they were dracula plugins.

For all custom:<plugin-name> :

  • @dracula-custom-<plugin-name>-colors is checked
  • else it fallbacks on @dracula-custom-plugin-colors or dracula defaults ("cyan dark_dray")
  • the colors is then applied as before

Assisted-by: Claude Code (Claude Sonnet 5, Claude Opus 5.5)

@abourjac
abourjac force-pushed the custom-plugins-colors branch 2 times, most recently from 518ee9c to 43ca2e1 Compare August 12, 2026 15:25
@abourjac

Copy link
Copy Markdown
Contributor Author

Added the forgotten Assisted-by commit trailer

@Theoreticallyhugo

Copy link
Copy Markdown
Collaborator

This is very cool, and I've tested it with bash and python and it works well.
However, I'm not sure about the removal of the trailing .sh.

Since users are still required to write custom:test.sh with the suffix, and we'll need the suffix for all other kinds of files, I don't think it really makes sense to carve out an exception for this one situation and case.

I'd probably prefer to merge this without the suffix truncation, but I'm open to counterarguments.

@abourjac

Copy link
Copy Markdown
Contributor Author

Glad you like it!
You'd rather have @dracula-custom-test.sh-colors as an option name?

@Theoreticallyhugo

Copy link
Copy Markdown
Collaborator

Honestly, yes. would be more in line with @dracula-custom-test.py-colors or @dracula-custom-test-colorsif you were to go with e.g. python or rust respectively.

@Theoreticallyhugo

Copy link
Copy Markdown
Collaborator

Also, please adapt /docs/color_theming/README.md. The alphabetically ordered block still lists @dracula-custom-plugin-colors. Linking to the config docu you added may make sense there too.

@Theoreticallyhugo Theoreticallyhugo added the breaking This breaks previous configs. label Sep 29, 2026
@abourjac

Copy link
Copy Markdown
Contributor Author

You're right, I forgot about scripts othen than bash.
Is it really a breaking change though? IMO it adds a new feature but breaks nothing, no?

Assisted-by: Claude Code (Claude Sonnet 5, Claude Opus 5.5)
@Theoreticallyhugo

Copy link
Copy Markdown
Collaborator

IMO it adds a new feature but breaks nothing, no?

Nope, you're right and I'm just too tired. I'm sorry

@Theoreticallyhugo Theoreticallyhugo added enhancement New feature or request and removed breaking This breaks previous configs. labels Sep 29, 2026
@abourjac
abourjac force-pushed the custom-plugins-colors branch from 43ca2e1 to 6f90407 Compare September 29, 2026 14:32
@abourjac

Copy link
Copy Markdown
Contributor Author

Ahah no problem :) Changes pushed, let me know if there's anything else.

@Theoreticallyhugo Theoreticallyhugo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two things I want to have acknowledged that these are "bugs" we don't need to fix. Just for future reference:

  • The custom- prefix avoids clashing, except when the custom plugin is called plugin. In that case @dracula-custom-<name-of-script>-colors would become the same as the old @dracula-custom-plugin-colors.
  • Scripts like a[1].sh could fail as [1] is interpreted as array index.

I'd like to keep this PR open for at least another day, so that other people have the chance to veto me or your new changes. If nothing new comes up, we'll just merge.

@Theoreticallyhugo
Theoreticallyhugo merged commit 87f3f11 into dracula:master Oct 14, 2026
1 check passed
@abourjac
abourjac deleted the custom-plugins-colors branch October 14, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants