perf: batch entry decryption into a single agent round trip - #359
Open
Chr1s70ph wants to merge 1 commit into
Open
perf: batch entry decryption into a single agent round trip#359Chr1s70ph wants to merge 1 commit into
Chr1s70ph wants to merge 1 commit into
Conversation
Finding an entry by name decrypts every entry in the vault (name, username, folder, notes, uris, custom fields), and each decryption was a separate request to the agent over a fresh socket connection. With a few hundred sequential round trips this took over a second on macos, where per-connection overhead is much higher than on linux. Add a DecryptMany action to the agent protocol that decrypts a batch of cipherstrings in one round trip, and drive the existing per-entry decryption functions through a record/replay decryptor: a recording pass collects every cipherstring they want (their control flow only depends on the entry structure, never on decrypted values), and after one batched request a replay pass hands the results back out in the same order. rbw get, search, and list all use the batch path now; master password reprompt semantics are unchanged since the agent runs the same per-item handler inside the batch. Commit was made in assistance with AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding an entry by name decrypts every entry in the vault (name, username, folder, notes, uris, custom fields), and each decryption was a separate request to the agent over a fresh socket connection. With a few hundred sequential round trips this took over a second on macos, where per-connection overhead is much higher than on linux.
Add a DecryptMany action to the agent protocol that decrypts a batch of cipherstrings in one round trip, and drive the existing per-entry decryption functions through a record/replay decryptor: a recording pass collects every cipherstring they want (their control flow only depends on the entry structure, never on decrypted values), and after one batched request a replay pass hands the results back out in the same order. rbw get, search, and list all use the batch path now; master password reprompt semantics are unchanged since the agent runs the same per-item handler inside the batch.
Commit was made in assistance with AI
Improves the performance Issues mentioned in #11
before:
after: