Haiku: Apply .NET-specific llvm-libunwind patches#126785
Open
trungnt2910 wants to merge 2 commits intodotnet:mainfrom
Open
Haiku: Apply .NET-specific llvm-libunwind patches#126785trungnt2910 wants to merge 2 commits intodotnet:mainfrom
trungnt2910 wants to merge 2 commits intodotnet:mainfrom
Conversation
.NET uses `setRegister` with 3 arguments, the last being a "location" for the register. For calls without a known location, `0` is passed.
Updated to include the patch at be5f98f for Haiku-specific `llvm-libunwind` code.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
As mentioned here: #55803 (comment) If this PR is approved, could you please merge instead of squashing/rebasing to retain the hash of the reference? Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vendored llvm-libunwind Haiku x86_64 sigreturn unwinding path to use the 3-argument setRegister(reg, value, location) form that .NET expects (passing 0 when no register location is tracked), and records the additional upstream patch reference.
Changes:
- Update Haiku x86_64
stepThroughSigReturn()to pass an explicitlocationargument (0) to all_registers.setRegister(...)calls. - Add the corresponding dotnet/runtime patch reference to
llvm-libunwind-version.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/native/external/llvm-libunwind/src/UnwindCursor.hpp |
Fix Haiku sigreturn register restoration call sites to match the 3-arg setRegister API usage (with location = 0). |
src/native/external/llvm-libunwind-version.txt |
Document the additional applied .NET patch commit for the vendored libunwind. |
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET uses
setRegisterwith 3 arguments, the last being a "location" for the register.For calls without a known location,
0is passed.This updates the recent Haiku-specific call sites to
setRegisterto match what .NET uses.Part of #55803.