fix(lib): doom/version without git checkout#8833
Open
marienz wants to merge 1 commit into
Open
Conversation
The locate-dominating-file check for Doom and its modules being in a Git repository before running git commands had its arguments reversed. It looks like this causes it to always return non-nil. Fix this to make the intended "not a git repo" show up when Doom is not in a git repo, while still showing the revision when in a git repo.
hlissner
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locate-dominating-file check for Doom and its modules being in a Git repository before running git commands had its arguments reversed. It looks like this causes it to always return non-nil.
Fix this to make the intended "not a git repo" show up when Doom is not in a git repo, while still showing the revision when in a git repo.
(I did not spot other locate-dominating-file calls with the same problem.)