Implement missing methods for GameAudio::Parameters - #75
Open
joakim-d wants to merge 1 commit into
Open
Conversation
joakim-d
commented
Aug 14, 2026
joakim-d
commented
Contributor
- Implement GameAudio::Parameters::setPlayerMode
- Implement GameAudio::Parameters::setRaceMode
- Set "Matching" for GameAudioParam.cpp
Report for MarioClub_us (55b9b9f - 10043e6)📈 Matched code: 46.66% (+0.05%, +1688 bytes) ✅ 7 new matches
|
joakim-d
commented
Aug 14, 2026
Comment on lines
+120
to
+121
| f32 _04; // 04 (referenceDistance) | ||
| f32 _08; // 08 (nearDistance) |
Contributor
Author
There was a problem hiding this comment.
FYI I did not rename those variables because another CPP file was being impacted and a LOT (+50) of unused symbols were preventing the build to pass.
I thought it was out of scope so I left it like so
SwareJonge
reviewed
Aug 15, 2026
Comment on lines
+147
to
+174
| const f32& minVolume = audience[0].setting_.minVolume; | ||
| const f32& refDistance = audience[0].setting_._04; | ||
| const f32& nearDistance = audience[0].setting_._08; | ||
|
|
||
| f32 fullVolume = 1.0f; | ||
| f32 volume2x = 2.0f; | ||
| f32 volume3x = 3.0f; | ||
| f32 volume4x = 4.0f; | ||
| f32 volumeHalf = 0.5f; | ||
| f32 volumeQuarter = 0.25f; | ||
| f32 volumeSixth = 0.16666667f; | ||
| f32 volumeEighth = 0.125f; | ||
|
|
||
| audience[0].mVolumeSlope2x = (minVolume - fullVolume) / (( refDistance * volume2x) - nearDistance); | ||
| audience[0].mVolumeSlope3x = (minVolume - fullVolume) / (( refDistance * volume3x) - nearDistance); | ||
| audience[0].mVolumeSlope4x = (minVolume - fullVolume) / (( refDistance * volume4x) - nearDistance); | ||
| audience[0].mVolumeSlopeHalf = (minVolume - fullVolume) / (( refDistance * volumeHalf) - nearDistance); | ||
| audience[0].mVolumeSlopeQuarter = (minVolume - fullVolume) / (( refDistance * volumeQuarter) - nearDistance); | ||
| audience[0].mVolumeSlopeSixth = (minVolume - fullVolume) / (( refDistance * volumeSixth) - nearDistance); | ||
| audience[0].mVolumeSlopeEighth = (minVolume - fullVolume) / (( refDistance * volumeEighth) - nearDistance); | ||
|
|
||
| audience[0].mDistanceThreshold2x = volume2x * refDistance; | ||
| audience[0].mDistanceThreshold3x = volume3x * refDistance; | ||
| audience[0].mDistanceThreshold4x = volume4x * refDistance; | ||
| audience[0].mDistanceThresholdHalf = volumeHalf * refDistance; | ||
| audience[0].mDistanceThresholdQuarter = volumeQuarter * refDistance; | ||
| audience[0].mDistanceThresholdSixth = volumeSixth * refDistance; | ||
| audience[0].mDistanceThresholdEighth = volumeEighth * refDistance; |
Collaborator
There was a problem hiding this comment.
This really looks like some inline to me, although i can't quite see how that'd look.
I believe the same code is in GameAudio::Main::init
Contributor
Author
There was a problem hiding this comment.
Indeed, I moved the code into GameAudioAudience.cpp
joakim-d
force-pushed
the
end_gameaudioparam_reversing
branch
2 times, most recently
from
August 16, 2026 17:54
d86e31a to
24c137c
Compare
joakim-d
force-pushed
the
end_gameaudioparam_reversing
branch
from
August 16, 2026 18:01
24c137c to
10043e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.