fix: Add parent constructor call in EnumReflectionProperty - #514
Merged
Merged
Conversation
greg0ire
reviewed
Jun 13, 2026
greg0ire
reviewed
Jun 13, 2026
greg0ire
left a comment
greg0ire
left a comment
Member
There was a problem hiding this comment.
Why did you not also backport the new tests?
jawira
force-pushed
the
call-reflection-parent
branch
from
June 13, 2026 09:14
6420737 to
e7d361a
Compare
Contributor
Author
It was an oversight, I have just commit the tests. |
jawira
force-pushed
the
call-reflection-parent
branch
from
June 13, 2026 13:15
e7d361a to
33fee23
Compare
jawira
force-pushed
the
call-reflection-parent
branch
from
June 13, 2026 13:18
33fee23 to
64a0222
Compare
greg0ire
approved these changes
Jun 13, 2026
Member
|
Thanks @jawira ! |
greg0ire
reviewed
Jun 13, 2026
| parent::__construct($originalReflectionProperty->class, $originalReflectionProperty->name); | ||
|
|
||
| $this->originalReflectionProperty = $originalReflectionProperty; | ||
| $this->enumType = $enumType; |
Member
There was a problem hiding this comment.
@jawira shouldn't these 2 lines have vanished? They are not present on 4.2.x
Contributor
Author
There was a problem hiding this comment.
@greg0ire Those two lines are present in the 4.2.x branch, but they are implemented using constructor property promotion.
I can't use the same syntax in the 3.4.x branch because constructor property promotion was introduced in PHP 8.0, while the minimum supported PHP version for 3.4.x is PHP 7.2. The syntax is different, but the semantics are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR is a backport of #422 to the 3.4.x branch.
The original fix was merged into 4.0.x, this PR applies the same solution to the 3.4.x branch.
The issue this PR solves is explained in: #423